Merged
Conversation
Updated G3X Serial input module to retrieve TAS and Density Altitude from G3X SID 2 instead of calculating them from values in SID 1
Fixed the TAS to MPH conversion (accounting for the 0.1kt resolution) and expand scope of branch to add autopilot bug settings.
Added UTF-8 Decoding to the N/S and E/W lat-long characters, as they were being read as "'b'N'" bytes. Also changed SentID to string and UTF-8 decoding sentence ID instead of reading int byte to better support installations where CNI data is enabled on the G3X textout format.
Added UTF-8 Decoding to the N/S and E/W lat-long characters, as they were being read as "'b'N'" bytes. Also changed SentID to string and UTF-8 decoding sentence ID instead of reading int byte to better support installations where CNI data is enabled on the G3X textout format.
Change ground speed reference source to SID 7 instead of calculating from GPS info
Collaborator
Author
|
@TopherTimeMachine I've been able to test on my G3X booth on macOS. I'm confident in the operation of this module to be robust. Please review. |
Collaborator
|
👍Sent from my iPhoneOn Aug 9, 2024, at 5:18 PM, Topher ***@***.***> wrote:
Merged #52 into master.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated G3X Serial input module to retrieve TAS and Density Altitude from G3X SID 2 instead of calculating them from values in SID 1
Solves issue #51