feat: enhance API token handling and playground UI notifications#360
Merged
bernirosas merged 4 commits intomainfrom Apr 6, 2026
Merged
feat: enhance API token handling and playground UI notifications#360bernirosas merged 4 commits intomainfrom
bernirosas merged 4 commits intomainfrom
Conversation
- Updated the global TS interface to make the token property optional. - Improved the demo HTML to include a notice for when no API token is set, informing users that events will be queued. - Modified the configuration form to allow for an empty token field, with a hint indicating that events will queue until a token is provided. - Enhanced JavaScript logic to manage event statuses based on the presence of a token, updating UI elements accordingly. - Added tests to ensure proper behavior when the token is missing, including capturing events and observing dynamically added elements. These changes improve user experience and ensure better handling of API token scenarios.
bernirosas
changed the title
bernirosas
changed the title
- Added a console log to notify when the API token is not set, indicating that events will be queued until the token is available. This enhances user awareness regarding token handling in the application.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
- Updated the README to specify that if a token is not provided during library initialization, the `window.TS.token` must be set for the event queue to flush. This enhances user understanding of the token requirement for event processing.
anonvt
previously approved these changes
Apr 6, 2026
Collaborator
anonvt
left a comment
anonvt
left a comment
There was a problem hiding this comment.
LGTM — the core design (queue pause + token watcher + drain) is sound, and the test coverage is solid. Nice UX improvement for the playground.
Left one nit on the watchForToken function.
anonvt
reviewed
Apr 6, 2026
- Updated the README to clarify that if a token is not provided during library initialization, events will be queued until the token is set via property assignment. - Added a warning against replacing the entire `window.TS` object after the library has loaded, as this would prevent the queued events from being sent. - Enhanced comments in `detector.ts` to reinforce the importance of direct property assignment for setting the token.
anonvt
approved these changes
Apr 6, 2026
anonvt
added a commit
that referenced
this pull request
Apr 15, 2026
## Summary - Bumps version to `2.8.0` - Fixes jsdom localStorage test failures on Node.js 25+ ## Changes since v2.7.0 ### Features - **Lazy token loading** — events queue when no API token is set and drain automatically when `window.TS.token` is assigned later (#360) - **Interactive playground** — new `/demo` page for testing the analytics library (#359) ### Fixes - Add `lang` attribute to HTML elements for a11y compliance (#355) - Configure jsdom for Node 25+ localStorage compatibility (`--no-experimental-webstorage`) ### Tests - New queue tests for memory store fallback and error handling (#358) ### Housekeeping - Dependency bumps: biome, react, express, msw, codecov-action, checkout, deploy-pages, upload-pages-artifact, pnpm/action-setup - Added CLAUDE.md (#354) ## Test plan - [x] `pnpm run lint:ci` passes - [x] `pnpm run types:check` passes - [x] `pnpm run test` — 47/47 tests pass (17 test files) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes improve user experience and ensure better handling of API token scenarios.