Skip to content

Unify PBC to be a torch.Tensor of bools #251

@curtischong

Description

@curtischong

Right now we do not have a standardized method to represent booleans. The code uses pbc=True and pbc=torch.Tensor([True,True,True]) interchangeably. I propose to change it all to torch.Tensor([True,True,True]). This is a breaking change but I think it's better than pbc=True because it brings us onto a path to implement axis-specific periodic boundaries.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions