-
Notifications
You must be signed in to change notification settings - Fork 70
Open
Description
When Vesin cut their 0.4.0 release, tests in test_neighbors.py started failing like so:
FAILED tests/test_neighbors.py::test_neighbor_list_implementations[vesin_nl-periodic_atoms_set-1] - ValueError: `periodic` must be a single boolean or a sequence of three booleans, got True of type <class 'numpy.ndarray'>
The proximate cause of this failure seems to be that vesin recently bumped to 0.4.0 (link). The relevant part of the release notes seems to be ...
The periodic argument to vesin_neighbors() in C and C++, NeighborList.compute() in all other languages can now be set separatly for each box dimension, allowing mixed periodic and non-periodic boundary conditions.
As a quick fix I pinned vesin to < 0.4.0, but we should go over how we're invoking vesin so we can unpin
Metadata
Metadata
Assignees
Labels
No labels