-
Notifications
You must be signed in to change notification settings - Fork 55
MAINT: update pins in MACE phonons example. Remove misleading ty from PR template #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughRemoved one checklist item from the PR template and relaxed/updated dependency version constraints in an example script and a docs helper (switched exact pins/exclusions to minimum-version constraints). No code logic, control flow, or public API changes. Changes
Sequence Diagram(s)(omitted — changes do not alter control flow or runtime interactions) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/scripts/6_Phonons/6.1_Phonons_MACE.py (1)
8-8: Consider capping Plotly to the current major to avoid surprise breakagesYou’ve addressed the 6.2.0 issue by requiring 6.3+, which is good. To reduce future break risk from a new major, consider adding an upper bound on the major version.
Apply this diff:
-# "plotly>=6.3.0", +# "plotly>=6.3.0,<7",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/PULL_REQUEST_TEMPLATE.md(0 hunks)examples/scripts/6_Phonons/6.1_Phonons_MACE.py(1 hunks)
💤 Files with no reviewable changes (1)
- .github/PULL_REQUEST_TEMPLATE.md
🔇 Additional comments (1)
examples/scripts/6_Phonons/6.1_Phonons_MACE.py (1)
7-7: Relaxed pymatviz pin to >=0.17.1 — LGTMThis aligns better with the example usage (phonon_dos/phonon_bands) and avoids the broken environment from the prior strict pin. No concerns.
New plotly release without fixing issue caused old pinning to break.
Summary by CodeRabbit