Skip to content

MAINT: update pins in MACE phonons example. Remove misleading ty from PR template #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025
Merged

MAINT: update pins in MACE phonons example. Remove misleading ty from PR template #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6369f9b
fix: pin plotly. remove misleading ty from PR template until we achie…
CompRhys Aug 13, 2025
0fbf953
bump pins
CompRhys Aug 13, 2025
7459871
fix tree map deps
CompRhys Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ Before a pull request can be merged, the following items must be checked:

* [ ] Doc strings have been added in the [Google docstring format](https://sphinxcontrib-napoleon.readthedocs.io/en/latest/example_google.html#example-google).
* [ ] Run [ruff](https://beta.ruff.rs/docs/rules/#pydocstyle-d) on your code.
* [ ] Run `uvx ty check` on the repo.
* [ ] Tests have been added for any new functionality or bug fixes.

We highly recommended installing the pre-commit hooks running in CI locally to speedup the development process. Simply run `pip install pre-commit && pre-commit install` to install the hooks which will check your code before each commit.
4 changes: 2 additions & 2 deletions docs/_static/draw_pkg_treemap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@

# /// script
# dependencies = [
# "pymatviz==0.16.0",
# "plotly!=6.2.0", # TODO remove pin pending https://github.com/plotly/plotly.py/issues/5253#issuecomment-3016615635
# "pymatviz>=0.17.1",
# "plotly>=6.3.0",
# ]
# ///

Expand Down
4 changes: 2 additions & 2 deletions examples/scripts/6_Phonons/6.1_Phonons_MACE.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
# dependencies = [
# "mace-torch>=0.3.12",
# "phonopy>=2.35",
# "pymatviz==0.16",
# "pymatviz>=0.17.1",
# "plotly>=6.3.0",
# "seekpath",
# "ase",
# "plotly!=6.2.0", # TODO remove pin pending https://github.com/plotly/plotly.py/issues/5253#issuecomment-3016615635
# ]
# ///

Expand Down