Rename and reorder some variables #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hey @thomasloux does this align with your thoughts in issue #308? |
thomasloux
requested changes
Oct 29, 2025
Collaborator
thomasloux
left a comment
thomasloux
left a comment
There was a problem hiding this comment.
Nice, only a couple of needed change to comply with state.system_attributes rules
Collaborator
Author
|
@thomasloux I think this should be working now. |
thomasloux
requested changes
Oct 31, 2025
thomasloux
approved these changes
Oct 31, 2025
Collaborator
thomasloux
left a comment
thomasloux
left a comment
There was a problem hiding this comment.
set default values first to pass tests. otherwise good for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Before a pull request can be merged, the following items must be checked: