Fix fairchem and neighbors tests #317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were seeing failures in CI like this:
It seems this is because Hugging Face changed the name of their CLI from huggingface-cli to hf. (details here) This PR updates our test setup to reflect this.
We were also seeing test failures in CI in test_neighbors.py that looked like this:
The proximate cause of this failure seems to be that vesin recently bumped to 0.4.0 (link). Their release notes mention that ...
I cut this issue to properly handle this change, but in the meantime I enforced vesin < 0.4.0 in pyproject.toml.
Checklist
Before a pull request can be merged, the following items must be checked:
We highly recommended installing the
prekhooks running in CI locally to speedup the development process. Simply runpip install prek && prek installto install the hooks which will check your code before each commit.