Merged
Conversation
…e bad interface to multisoftsphere
Member
Author
|
The PR was looking so clean until these tests broke. They all use LJ models and have numerical consistency issues. Not sure what the bug might be :( |
…se to break symmetry without needing "noisier model" bump noise a lot on base model, do not limit tests to CPU
orionarcher
approved these changes
Mar 5, 2026
Collaborator
There was a problem hiding this comment.
Very nice change. Love the amount of code deleted.
I'd favor adding more documentation explaining the new pair potential structure / design. In the pair_potential.py module header or in the headers or class descriptions of the models themselves.
The amount of deleted testing in the pair potentials worries me slightly. In theory it'd be nice if most of the tests passed as is. I will trust that the lost test coverage has been replaced by the newly added tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all the old classical pair potential backends with general backend, make this differentiable to enable
diff_sim.pyto work.