Conversation
|
Is TorchSim doing semver or not? I.e. does going from 0.5.x to 0.6.0 indicate breaking changes, or "a collection of major improvements"? What the pin is trying to prevent is some user installing an old version of metatomic-torchsim with a recent version of torchsim that contains breaking changes and is no longer compatible. So if you use semver we can update the pin to be <0.7, and otherwise we can maybe drop the pin. Although then I'm wondering how you want to deal with future breaking changes in torchsim's API? |
|
my understanding of semver is that until we issue a 1.0.0 all 0.x.y are allowed to be breaking because the API is still in flux. Once we get a 1.0.0 release then we would increment the first digit for breaking changes but as there is still flux in the public API (e.g. adding the "extras") then we're still a little way off doing that. |
|
Yes, sorry, I'm typically using the semver extension from cargo and did not make that clear:
I find this helps with not having to pin to one specific version, and matches how people tend to think/use versions in practice. This is mostly unrelated to this discussion though, my main question is how do you plan to handle breaking changes in TorchSim? I.e. what happen if you add a new required parameter to a function/rename a class? I'm happy to remove the upper-version pin in metatomic-torchsim if you think this will work better overall! |
|
I don't think there's actually any way to avoid breaking CI if we have upper pins. Atleast whilst we wrap the interface in the package we would catch any issues with the latest release incompatibility with you guys before we cut a release and so on the assumption we continue to actively maintain torchsim in a responsive manner then I think it's fine to remove the upper pin on the basis that we're not planning to make many breaking changes even if we're still not close to 1.x.x and so not having the upper pin reduces the total number of PRs needed. |
|
metatomic-torchsim v0.1.2 is now on PyPI if you want to try CI again! |
Cut a new release