Allow Player class derivatives to override NumTableActionAnims#1713
Merged
Azaezel merged 1 commit intoTorqueGameEngines:developmentfrom Apr 19, 2026
Merged
Conversation
the player class (and resource derivatives, contain a mix of hardcoded animation names, as well as scriptable ones that can be tripped via playthread/setActionThread. to determine if an animation within the stored vector is hardcoded or a scripted oneoff for that mesh, theres a demarcation at NumTableActionAnims for the up to 512 animation slots available. when deriving from player, we must therefore allow that entry to be overridden for any class which adds additional hardcoded animations therefore this introduces a datablock-level entry for the marked slot.
Azaezel
added a commit
to Azaezel/AAK
that referenced
this pull request
Apr 14, 2026
as a followup to TorqueGameEngines/Torque3D#1713 this ditches a bit more of the doubled up code in player, and leverages the hardcoded vs dynamic animation split-point override code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the player class (and resource derivatives, contain a mix of hardcoded animation names, as well as scriptable ones that can be tripped via playthread/setActionThread. to determine if an animation within the stored vector is hardcoded or a scripted oneoff for that mesh, theres a demarcation at NumTableActionAnims for the up to 512 animation slots available. when deriving from player, we must therefore allow that entry to be overridden for any class which adds additional hardcoded animations therefore this introduces a datablock-level entry for the marked slot.