Script Fix for Parent call that does not use %this #1752
Merged
Azaezel merged 1 commit intoMay 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have explained this in the commented section above the commented out check but callArgv[1] usually refers to %this being passed into a Parent::function, this was creating a state where all parent calls that had arguments but didnt utilize %this it was expecting the first argument to always be an object. Hence if you tried to call a method that took a different argument it incorrectly reported with a misleading error of "unable to find object"
There may be a better way to enforce this rule without commenting it out entirely but due to the nature of the callArgv handle it is always either an object or it isnt. Forcing a break on null causes an issue that shouldnt have been one in a parent call.
Bug Reported by Abbey: https://discord.com/channels/358091480004558848/783127087820439582/1509827504402333848