fix(setup-banner): #24 — name env vars in copy, fix docsUrl, document auto-banner#77
Merged
TortoiseWolfe merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
… auto-banner The SetupBanner component already shipped (5-file pattern, consent-aware, auto-detects via isSupabaseConfigured()). #24 closes by improving three small clarity gaps the audit identified at docs/interoffice/audits/ 2026-05-02-supabase-banner-audit.md: 1. Default message named the env vars to set. Fork users seeing "Supabase is not configured. Some features may be unavailable." couldn't tell which two NEXT_PUBLIC_* vars to populate. New copy: "Supabase is not configured: set NEXT_PUBLIC_SUPABASE_URL and NEXT_PUBLIC_SUPABASE_ANON_KEY in your .env file." 2. Default docsUrl points at the actual setup guide. Was pointing at github.com/.../ScriptHammer#supabase-setup — a non-existent README anchor. Now points at docs/FORKING.md#supabase-setup, which exists and is the canonical setup walkthrough. 3. docs/FORKING.md mentions the auto-banner. Added a paragraph at the top of the Supabase Setup section explaining the banner is intentional, auto-disappears once env vars are populated, and is dismissible. Fork users were arriving at FORKING.md with no indication that the yellow alert wasn't a bug. Tests: kept the existing default-prop test (URL match updated to new href). Added a regression pin asserting both env-var names appear in the default message, so a future copy refactor can't drop one. Verification: - pnpm run type-check: clean - pnpm run lint: clean - pnpm test: 3248/3248 pass (one new regression test) Closes #24 Refs: PRP at docs/prp-docs/supabase-banner-clarity-prp.md (Option A chosen for docsUrl — direct link to FORKING.md, no README change) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
TortoiseWolfe
added a commit
that referenced
this pull request
May 6, 2026
Phase 0 (template hygiene for forks) closed this session via 5 PRs: - #77 (#24) SetupBanner clarity - #70 (#69) Docker volume permissions - #78 (#22) Mobile-First Web Vitals instrumentation - #79 (#73) Constitution v1.0.2 wireframe gate - #81 (#21) WCAG AAA scope upgrade STATUS.md updates: - Snapshot date: 2026-04-27 → 2026-05-06 - Stability blurb: rewritten to reflect Phase 0 closure - 001 WCAG: [~] → [x] AAA standard, ContactForm green, overlay → #80 - 004 Mobile-First: [~] → [x] Web Vitals through GoogleAnalytics - 006 Template Fork: [~] → [x] SetupBanner + Docker volume fix - 015 OAuth Display Name: [~] → [x] full cascade with GitHub fixtures - Summary table: Shipped count 18 → 22 Inventories regenerated via scripts/refresh-inventories.py: - skill-index.md (22 items) - workflow-status.md (7 items) - security-touchpoints.md (45 items) - screen-inventory.md (25 items) Pure documentation; no code changes. Co-authored-by: TurtleWolfe <TurtleWolfe@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small clarity gaps in the SetupBanner that fork users hit on first run with empty Supabase config. The component itself already shipped (5-file pattern, consent-aware, auto-detects via `isSupabaseConfigured()`); this PR closes the remaining copy/docs gaps identified by the 2026-05-02 audit.
What changed
1. Default message names the env vars
Was: `Supabase is not configured. Some features may be unavailable.` — fork users couldn't tell which two `NEXT_PUBLIC_*` vars to populate.
Now: `Supabase is not configured: set NEXT_PUBLIC_SUPABASE_URL and NEXT_PUBLIC_SUPABASE_ANON_KEY in your .env file.`
2. Default docsUrl points at the actual setup guide
Was: `github.com/.../ScriptHammer#supabase-setup` — non-existent README anchor.
Now: `github.com/.../docs/FORKING.md#supabase-setup` — exists, canonical setup walkthrough.
3. `docs/FORKING.md` mentions the auto-banner
Added a paragraph at the top of the Supabase Setup section explaining the banner is intentional, auto-disappears once env vars are populated, and is dismissible. Fork users were arriving at FORKING.md with no indication that the yellow alert wasn't a bug.
Tests
Verification
Refs
Closes
Closes #24
🤖 Generated with Claude Code