fix(engineio/v3): incorrect NOOP packet formating when upgrading#560
Merged
fix(engineio/v3): incorrect NOOP packet formating when upgrading#560
NOOP packet formating when upgrading#560Conversation
Totodore
added
C-Bug
Totodore
force-pushed
the
improve-test-suites
branch
from
6ae7200 to
5e7ad5b
Compare
Totodore
changed the title
NOOP packet formating when upgrading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug introduced in #554, the
NOOPpacket sent in case of polling request while upgrading was incorrectly encoded as binary for v3 sockets with binary supports.