Add more logging around active_drop_spawns#1941
Merged
Merged
Conversation
MarcusSorealheis
approved these changes
Sep 26, 2025
palfrey
force-pushed
the
active-drop-spawns-logging
branch
from
46bbc04 to
f475f9d
Compare
MarcusSorealheis
pushed a commit
to MarcusSorealheis/nativelink
that referenced
this pull request
Nov 3, 2025
MarcusSorealheis
added a commit
to MarcusSorealheis/nativelink
that referenced
this pull request
Nov 4, 2025
new commit because lots of changes, generated protos and added metadata, support for lifecycle management stop failing tests asserting that the module compiles may not be necessary. Rust will tell us. reduced race window caused by global static OPEN_FILE_SEMAPHORE remove unusable test for now fix ref to non-existent file. remove errant test stub. remove one more test remove final test copied to test file convert sandbox dir to empty string add Java-specific example Update the Nativelink pricing in the website (TraceMachina#1921) Update the Nativelink docs to include Persistent Worker Builds Update the Nativelink Docs to clarify persistent worker usage Update product pricing p2 (TraceMachina#1923) * Update Product pricing features Fix bazelrc with generate Add worker_find_logging (TraceMachina#1925) Format JSON files (TraceMachina#1927) Support pre-0.7.0 cacheable spelling (TraceMachina#1926) Fix JSON formatting Update dependency astro to v5.13.2 [SECURITY] (TraceMachina#1890) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> add wrapper script from local and more tests add worker runner test gen proto Add ONTAP S3 Store with existence cache (TraceMachina#1630) * Add ONTAP S3 Store with existence cache Implements a NetApp ONTAP S3 compatible backend with an existence cache for better performance when checking if objects exist. This provides a specialized S3 implementation for NetApp ONTAP system with optimized handling for Content Addressable Storage. Signed-off-by: Kadam (EXT), Prajwal v08wha <prajwal.kadam.ext@siemens.com> * Ontap: Various fixes for the s3-compatible store Rebase Ontap S3 store against the latest main --------- Signed-off-by: Kadam (EXT), Prajwal v08wha <prajwal.kadam.ext@siemens.com> Co-authored-by: Tom Parker-Shemilt <tom@tracemachina.com> re-add sandbox_dir and regen protos Revert ExecutionComplete early scheduling optimization (TraceMachina#1929) * Revert "Early scheduling (TraceMachina#1904)" This reverts commit 85c279a. * Revert Early Scheduling to fix the Build Panics a license to protect the team (TraceMachina#1930) * a license to protect the team * fix nix. * update protos * update stranglers and header generator * Fix protos licenses * Fix non-executable scripts * Fix remaining other Apache licenses * tsan.sh was missing executable --------- Co-authored-by: Tom Parker-Shemilt <tom@tracemachina.com> Correct licensing Make npm tests run again Prepare `0.7.1` Release (TraceMachina#1932) * bump version * update BUILD files * fix clippy warnings * wrestling clippy on statements * remove todo!() added for ISA support * update behaviors in tests * Fix .bazelrc --------- Co-authored-by: Tom Parker-Shemilt <tom@tracemachina.com> Release Nativelink v0.7.1 (TraceMachina#1935) * Release Nativelink v0.7.1 * generate CHANGELOG * larify license changes Add trending badge (TraceMachina#1936) LastMile AI case study (TraceMachina#1937) * LastMile AI case study * fix image and configs * fix ordering and spacing * revert tsconfig change * fix formatting in json configs Make the error on a size field clearer (TraceMachina#1939) Previously, it said "no value can be found" which is a bit unclear Add more logging around active_drop_spawns (TraceMachina#1941) added validation warnings (TraceMachina#1938) * added validation warnings * change docker command * a few small changes * Update Dockerfile and README * Add Multi-worker README update hero with trademark (TraceMachina#1942) Better logging for store_awaited_action update failures (TraceMachina#1940) Unbreak docker-compose workflow (TraceMachina#940) Fixes TraceMachina#939 add actions Fix clippy warnings in persistent workers implementation - Add backticks to documentation for `KnownPlatformPropertyProvider` - Add backticks to documentation for `FastSlowStore` - Replace for_each with for loop in noop_store - Remove needless return statements in running_actions_manager All clippy warnings have been resolved with -D warnings flag. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We've seen some scenarios where our temp storage exceeds the expected usage of said, despite deletes occurring. One possibility there is that we've got a lot of extra delete spawns in flight and this PR adds logging around that.
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
bazel test //...Checklist
bazel test //...passes locallygit amendsee some docsThis change is