Merged
Conversation
Collaborator
Author
|
I could in theory make this backwards compatible, but I think it's way nicer to just bump the major and require workers and schedulers to be updated at the same time. |
5 tasks
Member
Wondering if we need to bump the major here. This will make schedulers and workers using different versions incompatible but IIRC we've never said that different versions are compatible with each other. We've generally done compatibility bumps only for client config breaks. |
chrisstaite-menlo
force-pushed
the
feature/Execution-complete
branch
from
2246ee2 to
6b61f0c
Compare
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
ce7b882 to
5c1e9dd
Compare
chrisstaite-menlo
force-pushed
the
feature/Execution-complete
branch
from
6b61f0c to
f1e1e05
Compare
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
5c1e9dd to
2d33b5d
Compare
chrisstaite-menlo
force-pushed
the
feature/Execution-complete
branch
from
f1e1e05 to
ecd52ac
Compare
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
2d33b5d to
758c63f
Compare
palfrey
approved these changes
Oct 16, 2025
Member
palfrey
left a comment
palfrey
left a comment
There was a problem hiding this comment.
@palfrey reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: 0 of 1 LGTMs obtained, and all files reviewed
palfrey
approved these changes
Oct 16, 2025
Member
palfrey
left a comment
palfrey
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 1 LGTMs obtained, and all files reviewed
chrisstaite-menlo
force-pushed
the
feature/Execution-complete
branch
from
ecd52ac to
ae25509
Compare
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
758c63f to
77e8307
Compare
Member
|
#1975 is now merged, and I'm guessing that's the source of conflicts here |
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
77e8307 to
0edaf6e
Compare
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Failure
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
Collaborator
Author
|
Rebased which sorted it out. Happy to merge this if you are. |
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
0edaf6e to
1ce866f
Compare
chrisstaite-menlo
temporarily deployed
to
production
GitHub Actions
Inactive
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Failure
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
Member
Seeing build failures now |
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
1ce866f to
6997213
Compare
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
e9a793e to
077070b
Compare
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
077070b to
e116664
Compare
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
e116664 to
389a5e1
Compare
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
389a5e1 to
c5d6166
Compare
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Failure
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Failure
chrisstaite-menlo
temporarily deployed
to
production
GitHub Actions
Inactive
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
c5d6166 to
81dc012
Compare
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
temporarily deployed
to
production
GitHub Actions
Inactive
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
81dc012 to
eb301cd
Compare
chrisstaite-menlo
temporarily deployed
to
production
GitHub Actions
Inactive
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Error
chrisstaite-menlo
had a problem deploying
to
production
GitHub Actions
Failure
When there are multiple schedulers in high availability mode then the workers can end up communicating with the wrong scheduler and state can get confused. Modify the communications such that there is a single bi-directional gRPC stream between the client and the worker. This way they will always be one-to-one mapped even with a load balancer in front.
chrisstaite-menlo
force-pushed
the
feature/Single-worker-stream
branch
from
eb301cd to
ac8f8ad
Compare
chrisstaite-menlo
temporarily deployed
to
production
GitHub Actions
Inactive
chrisstaite-menlo
temporarily deployed
to
production
GitHub Actions
Inactive
chrisstaite-menlo
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
pushed a commit
to MarcusSorealheis/nativelink
that referenced
this pull request
Nov 3, 2025
When there are multiple schedulers in high availability mode then the workers can end up communicating with the wrong scheduler and state can get confused. Modify the communications such that there is a single bi-directional gRPC stream between the client and the worker. This way they will always be one-to-one mapped even with a load balancer in front. Co-authored-by: Chris Staite <chris@yourdreamnet.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When there are multiple schedulers in high availability mode then the workers can end up communicating with the wrong scheduler and state can get confused.
Modify the communications such that there is a single bi-directional gRPC stream between the client and the worker. This way they will always be one-to-one mapped even with a load balancer in front.
Type of change
Please delete options that aren't relevant.
not work as expected)
How Has This Been Tested?
Running on my cluster this now functions perfectly with a one-to-one worker to scheduler and removes the races.
Checklist
bazel test //...passes locallygit amendsee some docsThis change is