Make all tests in running_actions_manager_test serial#1984
Merged
palfrey merged 2 commits intoTraceMachina:mainfrom Oct 16, 2025
Merged
Make all tests in running_actions_manager_test serial#1984palfrey merged 2 commits intoTraceMachina:mainfrom
palfrey merged 2 commits intoTraceMachina:mainfrom
Conversation
MarcusSorealheis
approved these changes
Oct 16, 2025
Collaborator
MarcusSorealheis
left a comment
MarcusSorealheis
left a comment
There was a problem hiding this comment.
It looked strange at first
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
added a commit
to MarcusSorealheis/nativelink
that referenced
this pull request
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
upload_with_single_permitinrunning_actions_manager_test.rsrelied on all of the other tests in that file being marked as#[serial], which wasn't the case and so we occasionally get breaks like https://github.com/TraceMachina/nativelink/actions/runs/18557949719/job/52899860136?pr=1980Given
serial_testsupports mod-level attributes we can fix this permanently by moving the attribute to that level. The diff looks large in Github, but locally the diff shows up as mostly just a whitespace change for most of the file.Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
bazel test //...Checklist
bazel test //...passes locallygit amendsee some docsThis change is