Require default-features=false for dependencies#1993
Merged
palfrey merged 2 commits intoTraceMachina:mainfrom Oct 18, 2025
Merged
Require default-features=false for dependencies#1993palfrey merged 2 commits intoTraceMachina:mainfrom
palfrey merged 2 commits intoTraceMachina:mainfrom
Conversation
palfrey
force-pushed
the
require-default-features
branch
from
3978c39 to
1aaf293
Compare
palfrey
force-pushed
the
require-default-features
branch
from
1aaf293 to
360b34b
Compare
palfrey
force-pushed
the
require-default-features
branch
from
360b34b to
e3f0370
Compare
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
added a commit
to MarcusSorealheis/nativelink
that referenced
this pull request
Nov 3, 2025
Co-authored-by: Marcus Eagan <marcuseagan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have a somewhat standard of requiring
default-features=falseand specifying the particular features needed from a crate to reduce the overall sprawl of dependencies. This wasn't enforced however, and we had a fair number of deps that did not use this.By editing https://www.schemastore.org/cargo.json and applying it as the schema for
Cargo.tomlfiles however we can make that format a requirement, which this PR does.Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
pre-commit mostly as we now run
taplo validateto find these issues.Checklist
bazel test //...passes locallygit amendsee some docsThis change is