Fix Fast slow store Not Found error by returning failed precondition#2194
Merged
amankrx merged 2 commits intoTraceMachina:mainfrom Feb 28, 2026
Merged
Conversation
amankrx
commented
Feb 26, 2026
| result: Some(execute_result::Result::InternalError(e.into())), | ||
| }).await.err_tip(|| "Error calling execution_response with error")?; | ||
| let is_cas_blob_missing = e.code == Code::NotFound | ||
| && e.message_string().contains("not found in either fast or slow store"); |
Collaborator
Author
There was a problem hiding this comment.
Not sure if this is the ideal way to ensure that the Not Found error indeed came from the Not found in fast or slow store, but I couldn't find any better way to ensure this scenario. This could break if we change the error message later down the line.
Collaborator
There was a problem hiding this comment.
You. need to add a test for this conditional that way we will know for sure if it breaks something in the future.
Collaborator
There was a problem hiding this comment.
We've done it. Claude was better at this than it had been with releases.
MarcusSorealheis
approved these changes
Feb 26, 2026
Tests the conditional that converts NotFound errors containing "not found in either fast or slow store" to FailedPrecondition, and verifies other NotFound errors still return InternalError. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Not Found error for fast and slow store by returning failed precondition instead of Internal error. This ensures that the bazel uploads the artifacts in the next retry instead of just retrying endlessly that was the case with the internal error.
Fixes #2184
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
I have tested this in production
Please also list any relevant details for your test configuration
Checklist
bazel test //...passes locallygit amendsee some docsThis change is