empty find_missing_blobs can return immediately#2217
Merged
palfrey merged 1 commit intoTraceMachina:mainfrom Mar 12, 2026
Merged
empty find_missing_blobs can return immediately#2217palfrey merged 1 commit intoTraceMachina:mainfrom
palfrey merged 1 commit intoTraceMachina:mainfrom
Conversation
Member
Author
|
/build-image nativelink-worker-init |
Member
Author
|
/build-image |
|
Image built and pushed! |
|
Image built and pushed! |
amankrx
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that #2188 is in to provide debug, I'm seeing a lot of this sort of message in Chromium builds
{"timestamp":"2026-03-12T11:35:11.157097Z","level":"DEBUG","fields":{"message":"ConnectionManager: request running","reason":"find_missing_blobs: []"},"target":"nativelink_util::connection_manager","span":{"name":"connection_manager_worker_spawn"},"spans":[{"name":"connection_manager_worker_spawn"}]}This is an empty
find_missing_blobs. Now, on the one hand, this should be pretty fast, but I'm seeing the gRPC flow clogged up with 100s of these waiting to be serviced and the overall time on that is non-trivial because of the request overhead. It's a bit of a weird request, but it's a case we should handle on a fast path.This PR explicitly makes the gRPC
find_missing_blobsreturn immediately for empty requests, and also implements that in general forStoreLikeas well inhas_manyandhas_with_resultsfor the empty cases.Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
bazel test //...and some Chromium build experimentsChecklist
bazel test //...passes locallygit amendsee some docsThis change is