Skip to content

empty find_missing_blobs can return immediately#2217

Merged
palfrey merged 1 commit intoTraceMachina:mainfrom
palfrey:fast-empty-find-missing-blobs
Mar 12, 2026
Merged

empty find_missing_blobs can return immediately#2217
palfrey merged 1 commit intoTraceMachina:mainfrom
palfrey:fast-empty-find-missing-blobs

Conversation

@palfrey
Copy link
Member

@palfrey palfrey commented Mar 12, 2026

Description

Now that #2188 is in to provide debug, I'm seeing a lot of this sort of message in Chromium builds

{"timestamp":"2026-03-12T11:35:11.157097Z","level":"DEBUG","fields":{"message":"ConnectionManager: request running","reason":"find_missing_blobs: []"},"target":"nativelink_util::connection_manager","span":{"name":"connection_manager_worker_spawn"},"spans":[{"name":"connection_manager_worker_spawn"}]}

This is an empty find_missing_blobs. Now, on the one hand, this should be pretty fast, but I'm seeing the gRPC flow clogged up with 100s of these waiting to be serviced and the overall time on that is non-trivial because of the request overhead. It's a bit of a weird request, but it's a case we should handle on a fast path.

This PR explicitly makes the gRPC find_missing_blobs return immediately for empty requests, and also implements that in general for StoreLike as well in has_many and has_with_results for the empty cases.

Type of change

Please delete options that aren't relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

bazel test //... and some Chromium build experiments

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@palfrey
Copy link
Member Author

palfrey commented Mar 12, 2026

/build-image nativelink-worker-init

@palfrey
Copy link
Member Author

palfrey commented Mar 12, 2026

/build-image

@github-actions
Copy link

Image built and pushed!

ghcr.io/TraceMachina/nativelink-worker-init:c2832dd

@github-actions
Copy link

Image built and pushed!

ghcr.io/TraceMachina/nativelink:c2832dd

@palfrey palfrey marked this pull request as ready for review March 12, 2026 12:59
@palfrey palfrey requested review from MarcusSorealheis and amankrx and removed request for MarcusSorealheis March 12, 2026 13:03
@palfrey palfrey merged commit dad870a into TraceMachina:main Mar 12, 2026
28 checks passed
@palfrey palfrey deleted the fast-empty-find-missing-blobs branch March 12, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants