fix: support custom AWS regions in AWS UDFs#2790
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
region_nameoverrides for generic AWS boto3 calls and Amazon S3 UDFs.AWS_REGIONfor host-side AWS role preprocessing, avoiding broad action-argument plumbing.Testing
uv run ruff check packages/tracecat-registry/tracecat_registry/integrations/aws_boto3.py packages/tracecat-registry/tracecat_registry/integrations/amazon_s3.py tracecat/executor/secret_preprocessors.py tests/unit/test_aws_assume_role.py tests/unit/test_executor_aws_assume_role.pyuv run basedpyright packages/tracecat-registry/tracecat_registry/integrations/aws_boto3.py packages/tracecat-registry/tracecat_registry/integrations/amazon_s3.py tracecat/executor/secret_preprocessors.py tests/unit/test_aws_assume_role.py tests/unit/test_executor_aws_assume_role.pyuv run pytest --confcutdir=tests/unit tests/unit/test_aws_assume_role.py tests/unit/test_executor_aws_assume_role.py -quv run python scripts/generate_tool_docs.py --checkgit diff --checkSummary by cubic
Adds per-call AWS region support to AWS UDFs and ensures STS AssumeRole uses the selected region. This lets workflows target GovCloud and other regions without changing global secrets.
region_nametotools.aws_boto3.call_apiandcall_paginated_api, and S3 actions (call_method,get_object,get_objects,list_objects,copy_objects,put_object,delete_object). Passed through toaioboto3/boto3sessions and clients.AWS_REGIONsecret to IRSA STS role preprocessing.aws_boto3andamazon_s3. Added targeted unit tests.Written for commit c28c2bd. Summary will update on new commits.