Remove hidden NetGuard lockdown feature#542
Merged
Conversation
NetGuard's app lockdown feature was hidden in TrackerControl (menu_lockdown had android:visible="false") and the "lockdown" pref defaulted to false with no UI to enable it. Remove all related code: - ServiceSinkhole: isLockedDown(), prepareUidIPFilters lockdown check, NOTIFY_LOCKDOWN constant, showLockdownNotification/removeLockdownNotification, notification icon lock/rocket conditional, lockdown SharedPreferences cleanup - Rule: lockdown field and SharedPreferences loading - AdapterRule: lockdown persistence and related-app propagation - ActivityMain: hidden menu item handler, legend lockdown icon - ActivitySettings: lockdown_wifi/lockdown_other pref listener, lockdown export/import in XML backup - XML: menu_lockdown item, legend lockdown entry Note: Android system VPN lockdown detection (always_on_vpn_lockdown in Settings.Secure) used in ActivityOnboarding and ActivityMain is preserved — that's a different feature that warns users about the system "Block connections without VPN" setting. https://claude.ai/code/session_01PuXevPG3gUKEXWHrgRMptV
Member
Author
|
@copilot the build fails |
…oval Agent-Logs-Url: https://github.com/TrackerControl/tracker-control-android/sessions/869a1602-7f49-4251-86af-cd1fdf728cf3 Co-authored-by: kasnder <5175206+kasnder@users.noreply.github.com>
Contributor
Fixed in 0ac34d4. The lockdown removal accidentally deleted the closing Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
}fordisable_on_callblock inActivitySettings.java(accidentally removed with lockdown code)