fix(ci): unify ui into pnpm workspace#49
Merged
luokerenx4 merged 1 commit intomasterfrom Mar 13, 2026
Merged
Conversation
The ui/ directory had its own pnpm-lock.yaml and `build:ui` used `cd ui && pnpm install`, which failed in CI because pnpm resolved to the root workspace instead of installing ui deps locally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uitopnpm-workspace.yamlso rootpnpm installcovers all depsui/pnpm-lock.yaml(consolidated into root lockfile)build:ui/dev:uito usepnpm --filter open-alice-uiFixes CI failure where
cd ui && pnpm installdidn't actually install ui dependencies because pnpm resolved to the root workspace.Test plan
pnpm install→ "Scope: all 3 workspace projects"pnpm buildpassespnpm test→ 592 tests pass🤖 Generated with Claude Code