Question about `run_while`

[lklein53]

Hello,

I was looking at the implementation of run_while and was wondering why its okay to not check the loop condition again after executing process_local_queue in the do_one function. Can't it happen that processing of the local queue would make the loop condition return false?
Couldn't this lead to a case where is_more_completed_work_pending is false, the loop condition would return false (but we are not checking it) and then end up with an infinite deadline in the do_one_completion_queue_event function?

Sorry if i am missing something obvious here.

thanks and best regards,
Lars

[Tradias]

That's an excellent question. I must admit that run_while deserves more unit tests then it currently has. Your case can indeed occur and is fixed in the next version (3.4.3).

[lklein53]

thanks for the quick fix and reply.