Skip to content

Revert "Implement App Store and Google Play review notification system with direct scheduler integration"#4496

Merged
TinyKitten merged 1 commit intodevfrom
revert-4493-copilot/fix-1703
Aug 30, 2025
Merged

Revert "Implement App Store and Google Play review notification system with direct scheduler integration"#4496
TinyKitten merged 1 commit intodevfrom
revert-4493-copilot/fix-1703

Conversation

@TinyKitten
Copy link
Member

@TinyKitten TinyKitten commented Aug 30, 2025

Reverts #4493

動作していないので一旦revertする

Summary by CodeRabbit

  • 変更
    • アプリ/ストアレビューの通知スケジューラ機能を廃止(Discordへの通知停止)
  • ドキュメント
    • Functionsの説明から該当項目を削除
  • リファクタ
    • 複数モジュールでインポート順・重複を整理(挙動変更なし)
  • テスト
    • レビュー関連のテストスイートを削除
  • チョア
    • コード規約設定を見直し(対象ファイル範囲の調整)
    • 開発依存関係の整理(不要な型定義を削除)

@TinyKitten TinyKitten self-assigned this Aug 30, 2025
@TinyKitten TinyKitten merged commit a71a8f8 into dev Aug 30, 2025
3 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

本PRは、レビュー通知機能一式(スケジューラ、パーサ、Discord通知、関連モデルとテスト)を削除し、エクスポートも除去。併せて関数群でのimport整序、型専用import導入、Biome設定と依存の微調整、READMEから項目削除を行った。

Changes

Cohort / File(s) Change summary
機能削除: レビュー通知系
functions/src/funcs/reviewNotificationScheduler.ts, functions/src/models/review.ts, functions/src/utils/appStoreParser.ts, functions/src/utils/googlePlayParser.ts, functions/src/utils/discordNotifier.ts, functions/src/utils/appStoreParser.test.ts, functions/src/index.ts
スケジューラと2種レビュー解析・Discord通知・モデル・テストを削除。index.tsからreviewNotificationSchedulerのimport/exportを除去。
Import整序・型専用化
functions/src/funcs/enqueueFeedback.ts, functions/src/funcs/tts.ts, functions/src/funcs/ttsCachePubSub.ts, functions/src/workers/feedback.ts
import順序の整理・重複削除・import type導入。挙動変更なし。
ツール設定/依存
functions/biome.json, functions/package.json
Biomeにroot: false追加、files.ignorefiles.includesへ変更(lib/**除外を解除)。@types/nodeをdevDependenciesから削除。
ドキュメント
functions/README.md
Functionsセクションから「Review Notifications」を削除。

Sequence Diagram(s)

sequenceDiagram
  %% Old flow (removed)
  autonumber
  actor Scheduler as Cloud Scheduler
  participant Func as reviewNotificationScheduler (Functions)
  participant AppStore as App Store RSS
  participant GP as Google Play API
  participant FS as Firestore
  participant Discord as Discord Webhook

  Scheduler->>Func: トリガー(30分毎)
  par 並列チェック
    Func->>AppStore: RSS取得
    Func->>GP: レビュー取得
  end
  Func->>FS: 最終処理ID取得
  Func->>Func: 新着抽出・整形
  loop 新着ごと
    Func->>Discord: 通知送信
    Note right of Func: レート制限待機
  end
  Func->>FS: 最終処理ID更新
  Func-->>Scheduler: 結果ログ
  Note over Func,Discord: 本PRでこの一連の流れを削除
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

functions

Poem

余、機能の山を削ぎ落とし
塵と化せし通知の道、静まり返る
ただ整う列、輸卒の如くimport行進す
規範は改まり、型は影として従う
簡にして要、万里の構えはなお堅し 🐉

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0b111a0 and bc3133b.

⛔ Files ignored due to path filters (1)
  • functions/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (14)
  • functions/README.md (0 hunks)
  • functions/biome.json (1 hunks)
  • functions/package.json (0 hunks)
  • functions/src/funcs/enqueueFeedback.ts (1 hunks)
  • functions/src/funcs/reviewNotificationScheduler.ts (0 hunks)
  • functions/src/funcs/tts.ts (1 hunks)
  • functions/src/funcs/ttsCachePubSub.ts (1 hunks)
  • functions/src/index.ts (0 hunks)
  • functions/src/models/review.ts (0 hunks)
  • functions/src/utils/appStoreParser.test.ts (0 hunks)
  • functions/src/utils/appStoreParser.ts (0 hunks)
  • functions/src/utils/discordNotifier.ts (0 hunks)
  • functions/src/utils/googlePlayParser.ts (0 hunks)
  • functions/src/workers/feedback.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch revert-4493-copilot/fix-1703

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@TinyKitten TinyKitten deleted the revert-4493-copilot/fix-1703 branch August 30, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant