Skip to content

RCTNewArchEnabled削除#4516

Merged
TinyKitten merged 1 commit intodevfrom
fix/ios-build-fail
Sep 24, 2025
Merged

RCTNewArchEnabled削除#4516
TinyKitten merged 1 commit intodevfrom
fix/ios-build-fail

Conversation

@TinyKitten
Copy link
Member

@TinyKitten TinyKitten commented Sep 24, 2025

Summary by CodeRabbit

  • チョア
    • iOS の複数ターゲットで内部設定を整理し、旧/新アーキテクチャ関連フラグを無効化。
    • App Clip、ウィジェット、拡張機能における実行時挙動の一貫性と互換性を改善。
    • 将来のビルド安定性と保守性を向上。
    • ユーザー影響: 機能変更はありませんが、全体の安定性が向上します。

@TinyKitten TinyKitten self-assigned this Sep 24, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 24, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

朕は各種 iOS ターゲット/スキームの Info.plist から RCTNewArchEnabled(true)を削除した。構造や他キーには変更無し。

Changes

Cohort / File(s) Change Summary
AppClip: Remove RCTNewArchEnabled
ios/CanaryAppClip/Info.plist, ios/ProdAppClip/Info.plist
ルート辞書から RCTNewArchEnabled(Boolean, true)を削除。他の項目は不変。
RideSessionActivity (Widget/Extension): Dev/Prod
ios/RideSessionActivity/Schemes/Dev/Info.plist, ios/RideSessionActivity/Schemes/Prod/Info.plist
NSExtension 配下の RCTNewArchEnabled(true)を削除。構造は維持。
TrainLCD: Dev/Prod
ios/TrainLCD/Schemes/Dev/Info.plist, ios/TrainLCD/Schemes/Prod/Info.plist
RCTNewArchEnabled(Boolean, true)を削除。他のキーは無変更。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

ios

Poem

朕の詔、ひとつの鍵を静かに退け
新架の旗、今は畳みて風止むのみ
plistの海、波紋なく澄み渡り
枠はそのまま、道は整う
小さき削除に、万里の備えあり 🏯✨

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/ios-build-fail

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 59a60b9 and 5a765a6.

📒 Files selected for processing (6)
  • ios/CanaryAppClip/Info.plist (0 hunks)
  • ios/ProdAppClip/Info.plist (0 hunks)
  • ios/RideSessionActivity/Schemes/Dev/Info.plist (0 hunks)
  • ios/RideSessionActivity/Schemes/Prod/Info.plist (0 hunks)
  • ios/TrainLCD/Schemes/Dev/Info.plist (0 hunks)
  • ios/TrainLCD/Schemes/Prod/Info.plist (0 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the ios label Sep 24, 2025
@TinyKitten TinyKitten merged commit c96c494 into dev Sep 24, 2025
3 of 4 checks passed
@TinyKitten TinyKitten deleted the fix/ios-build-fail branch September 24, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant