Fix TTS memory leaks causing failure after extended usage#4615
Merged
TinyKitten merged 2 commits intodevfrom Nov 15, 2025
Merged
Fix TTS memory leaks causing failure after extended usage#4615TinyKitten merged 2 commits intodevfrom
TinyKitten merged 2 commits intodevfrom
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note
|
- Improve AudioPlayer event listener cleanup in useTTS.ts - Add cleanup of existing players before creating new ones - Add error handling and logging for TTS operations - Implement cache size limit (MAX_CACHE_SIZE=50) in useTTSCache.ts - Add comprehensive tests for cache size limitation - Fix linting and formatting issues Co-authored-by: TinyKitten <32848922+TinyKitten@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix TTS not functioning after extended use
Fix TTS memory leaks causing failure after extended usage
Nov 15, 2025
TinyKitten
approved these changes
Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TTS stops working after prolonged app usage on iOS/Android due to AudioPlayer resource leaks and unbounded cache growth.
Core Issues
AudioPlayer resource leaks:
play()failures leave resources danglingUnbounded memory growth:
Changes
src/hooks/useTTS.tsplay()with full resource teardown on failurefetchSpeech()and HTTP failuressrc/hooks/useTTSCache.tsMAX_CACHE_SIZE = 50src/hooks/useTTSCache.test.tsExample
Before:
After:
Note
File system cache (MP3 files) still unbounded - follow-up issue for disk cleanup strategy.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.