Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. Note
|
| Cohort / File(s) | Summary |
|---|---|
GitHub Actions ワークフロー新規追加 .eas/workflows/create-beta-builds.yml |
ベータブランチへのプッシュでトリガーされる新しいワークフローを追加。Android ビルドジョブ (production プロファイル) と Google Play Store への自動送信ジョブを定義。環境変数から base64 エンコードされた認証情報 (.env.local、Sentry、Google Services JSON、署名鍵、Gradle プロパティなど) をデコードして復元。 |
EAS 本番環境設定 eas.json |
build.production に android.gradleCommand、ios スキーム/buildConfiguration を追加。submit.production に android トラック/applicationId、ios ascAppId/bundleIdentifier を追加し、プラットフォーム固有の本番ビルド・送信設定を強化。 |
Sequence Diagram(s)
sequenceDiagram
participant GitHub as GitHub Push<br/>(beta branch)
participant Workflow as GitHub Actions<br/>Workflow
participant Build as EAS Build<br/>(Android)
participant Submit as EAS Submit<br/>(Play Store)
GitHub->>Workflow: Trigger: push to beta
Workflow->>Workflow: Decode secrets<br/>.env.local, Sentry,<br/>Google Services, JKS, Gradle
Workflow->>Build: Run build job<br/>(production profile)
Build->>Build: Compile Android app
Build-->>Workflow: build_id
Workflow->>Submit: Run submit job<br/>(needs: build_android)
Submit->>Submit: Upload to Play Store
Submit-->>Workflow: Submission complete
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~10 minutes
- 注意点: 環境変数の base64 デコード処理が正しく実装されているか確認 (特に
.env.local、sentry.properties、google-services.json) - 注意点: EAS build/submit の設定値が本番環境に適切に対応しているか確認 (android track、applicationId、ios ascAppId など)
- 注意点: GitHub Actions シークレット側の設定が完了しているか外部で確認が必要
Suggested labels
ios, android
Poem
🐇 ベータなビルド、ワークフロー流れ
シークレットたちを base64 に包み
Play Store へ駆ける Android の力
本番設定、しっかり整えて
🎉 スムーズにリリース
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
fix/beta-dev-conflict
📜 Recent review details
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.eas/workflows/create-beta-builds.yml(1 hunks)eas.json(2 hunks)
Comment @coderabbitai help to get the list of available commands and usage tips.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
リリースノート
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.