SelectBoundModalで読み込み中は設定ボタン以外は無効化#5283
Merged
TinyKitten merged 1 commit intodevfrom Feb 14, 2026
Merged
Conversation
Contributor
📝 WalkthroughウォークスルーSelectBoundModal.tsx のUI制御にローディング状態の処理が追加されました。RouteInfo ボタンがローディング中に無効化され、TrainType と Save Route アクションもローディング状態を考慮するように拡張されました。 変更内容
コード確認の推定工数🎯 2 (Simple) | ⏱️ ~8 分 関連する可能性のあるPR
推奨ラベル
詩
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Comment |
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/SelectBoundModal.tsx (1)
586-591:⚠️ Potential issue | 🟡 Minor読み込み中は「閉じる」も無効化が必要です。
PR目的「設定ボタン以外は無効化」に対して、閉じるボタンが有効のままです。修正案
<Button style={styles.closeButton} textStyle={styles.closeButtonText} onPress={onClose} + disabled={loading} > {translate('close')} </Button>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
バグ修正