Merged
Conversation
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* プリセット名入力モーダルの追加とwantedDestinationIdのサポート Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * テストデータにwantedDestinationIdを追加し型エラーとテスト失敗を修正 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * LEDテーマでのプレースホルダー視認性改善とDB初期化のカラム存在チェックを修正 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * wantedDestinationIdを使ってPresetCardの表示区間とプリセット適用時の終着駅を正しく反映 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * プリセット機能の大幅改善: direction/notifyStationIds保存、始発駅選択UI、PresetCard表示改善 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * CommonCardにアコーディオン機能を追加しStationSettingsModalを廃止 - CommonCardにexpandableContent/expanded/onExpandedChange propsを追加 - RouteInfoModalで駅カードのアコーディオン内に通知・終着駅設定を表示 - SelectBoundModalからStationSettingsModal依存を除去 - CustomModalのレスポンダー戦略を修正しネストされたコントロールのタップを改善 - usePresetCarouselDataのキーをfetchKey/displayKeyに分割し不要な再取得を防止 - SavedRouteのnotifyStationIdsにdefault([])を追加 - SelectBoundModalのcurrentIdx===destIdx時の分岐を修正 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * レビュー指摘の修正: テーマ対応テキスト色、sentinel値防止、transition中のボタン無効化、fetch競合対策 - RouteInfoModal: expandableToggleTextをLEDテーマ対応に分岐 - SelectBoundModal: handleToggleNotificationでstation.id nullチェックを追加し-1 sentinel防止 - SelectBoundModal: isTransitioning中に停車駅一覧・種別・保存・設定ボタンも無効化 - usePresetCarouselData: requestIdによるfetch競合対策を追加 - usePresetCarouselData: displayKeyにnotifyStationIdsを追加 - SelectBoundModal: effectiveStationのコメントを実態に合わせて修正 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * 方向判定の-1ガード追加、プリセット保存時のnotifyStationIdsフィルタリング、carouselData ref化 - SelectBoundModal: findIndexが-1や等値を返す場合の方向判定を安全に処理 - SelectBoundModal: プリセット保存時にnotifyStationIdsを有効な駅IDでフィルタリング - SelectBoundModal: presetDirectionOptionsのコメントを汎用的に修正 - usePresetCarouselData: carouselDataRefを導入しdepsからcarouselDataを除去して余分な再レンダリングを防止 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * CustomModalのコンテンツ領域タップでモーダルが閉じる問題を修正 pointerEvents="box-none"だとコンテンツの空白部分のタップがバックドロップに 貫通していたため、pointerEvents="auto"に変更してコンテンツ領域でタッチを受け取るようにした Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * wantedDestinationによる区間絞り込みをnotifyStationIdsとRouteInfoModalに適用、fetch重複防止 - SelectBoundModal: effectiveStationsをwantedDestinationで切り出し、stationsWithoutPassと notifyStationIdsフィルタリングの両方に適用 - usePresetCarouselData: fetchKey を即座にマークして同一キーの重複fetchを防止、 エラー時にリセットしてリトライ可能に Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * SavePresetNameModalのdefaultName組み立てを中間変数に分離して可読性を改善 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * プリセット保存失敗時にモーダルを閉じないよう修正 setIsPresetNameModalVisibleをsaveCurrentRoute成功後に移動し、 失敗時はモーダルを維持してエラートーストを表示するようにした Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Co-authored-by: TinyKitten <32848922+TinyKitten@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.