GitHub ActionsのusesをコミットSHAにピン留め (Closes #1499)#1522
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough本番・ステージング環境のECSデプロイワークフローにおいて、GitHub Actionsの参照がメジャーバージョンタグ( ChangesGitHub Actions SHA固定
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ECSデプロイワークフロー(ステージング・本番)の GitHub Actions
uses:参照をバージョンタグ(@v*)から完全長のコミット SHA に変更し、確定的・再現可能なデプロイとサプライチェーン上のセキュリティを強化する。元タグは# v4のようにコメントで併記して Dependabot が追従できる形を維持。変更の種類
変更内容
.github/workflows/deploy_ecs_staging_stationapi.ymlおよび.github/workflows/deploy_ecs_production_stationapi.ymlの以下 5 アクションをコミット SHA に固定(両ファイルとも同じ SHA を使用)。actions/checkout@v4→actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4aws-actions/configure-aws-credentials@v4→aws-actions/configure-aws-credentials@7474bc4690e29a8392af63c5b98e7449536d5c3a # v4aws-actions/amazon-ecr-login@v2→aws-actions/amazon-ecr-login@fa648b43de3d4d023bcb3f89ed6940096949c419 # v2aws-actions/amazon-ecs-render-task-definition@v1→aws-actions/amazon-ecs-render-task-definition@6853cfae8c3a7d978fbf68b5a55453395541dfbb # v1aws-actions/amazon-ecs-deploy-task-definition@v2→aws-actions/amazon-ecs-deploy-task-definition@a310a830f5c14e583e35d84e4e1ec7dd177c3c9c # v2各 SHA は GitHub API(
repos/<owner>/<repo>/git/ref/tags/<tag>)で当該タグが指す実コミットを参照して取得。configure-aws-credentials@v4は annotated tag のため、タグオブジェクトから実コミット SHA を解決した。テスト
cargo fmt --all -- --checkが通ることcargo clippy -- -D warningsが通ることcargo test(SQLX_OFFLINE=true)が通ること省略: コード(
stationapi/**ほか)の変更なし、ワークフローファイルのみの変更のためcargoチェックは対象外。関連Issue
Closes #1499
スクリーンショット(任意)
Summary by CodeRabbit
Release Notes