Skip to content

use results in callback aggregate #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

use results in callback aggregate #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a66d89d
use results in callback aggregate
StuartFerguson Sep 18, 2025
1edac76
Merge branch 'main' into task/#122_aggregate_results
StuartFerguson Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CallbackHandler.BusinessLogic/Services/CallbackDomainService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,10 @@ public async Task<Result> RecordCallback(Guid callbackId,
DomainServiceHelper.HandleGetAggregateResult(getResult, callbackId, false);

CallbackMessageAggregate aggregate = callbackMessageAggregateResult.Data;
aggregate.RecordCallback(callbackId, typeString, messageFormat, callbackMessage, reference, destinations,
Result stateResult = aggregate.RecordCallback(callbackId, typeString, messageFormat, callbackMessage, reference, destinations,
Guid.Parse(estateReference), Guid.Parse(merchantReference));

if (stateResult.IsFailed)
return stateResult;
return await this.AggregateRepository.SaveChanges(aggregate, cancellationToken);
}
}
Expand Down
5 changes: 4 additions & 1 deletion CallbackHandler.CallbackMessageAggregate.Tests/CallbackMessageAggregateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
using SimpleResults;

namespace CallbackHandler.CallbackMessageAggregate.Tests
{
using CallbackHander.Testing;
Expand All @@ -20,8 +22,9 @@ public void CallbackMessageAggregate_RecordCallback_CallbackIsRecorded()
{
CallbackMessageAggregate aggregate = new CallbackMessageAggregate();

aggregate.RecordCallback(TestData.CallbackId, TestData.TypeString, MessageFormat.JSON, TestData.CallbackMessage, TestData.Reference, TestData.Destinations,
Result result = aggregate.RecordCallback(TestData.CallbackId, TestData.TypeString, MessageFormat.JSON, TestData.CallbackMessage, TestData.Reference, TestData.Destinations,
TestData.EstateReference, TestData.MerchantReference);
result.IsSuccess.ShouldBeTrue();

aggregate.ShouldSatisfyAllConditions(() => aggregate.CallbackMessage.ShouldBe(TestData.CallbackMessage),
() => aggregate.TypeString.ShouldBe(TestData.TypeString),
Expand Down
5 changes: 4 additions & 1 deletion CallbackHandler.CallbackMessageAggregate/CallbackMessageAggregate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Runtime.CompilerServices;
using SimpleResults;

namespace CallbackHandler.CallbackMessageAggregate
{
Expand Down Expand Up @@ -49,7 +50,7 @@ public static void PlayEvent(this CallbackMessageAggregate aggregate, CallbackRe
aggregate.Destinations.Add(domainEvent.Destination);
}

public static void RecordCallback(this CallbackMessageAggregate aggregate,
public static Result RecordCallback(this CallbackMessageAggregate aggregate,
Guid aggregateId,
String typeString,
MessageFormat messageFormat,
Expand All @@ -66,6 +67,8 @@ public static void RecordCallback(this CallbackMessageAggregate aggregate,

aggregate.ApplyAndAppend(callbackReceivedEvent);
}

return Result.Success();
}

internal static DomainEvent CreateCallbackReceivedEvent(this CallbackMessageAggregate aggregate,
Expand Down
Loading