Skip to content

refactor: rename DockerHelper subclass to CallbackHandlerDockerHelper #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2025
Merged

refactor: rename DockerHelper subclass to CallbackHandlerDockerHelper #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c2dfd4
refactor: rename DockerHelper subclass to CallbackHandlerDockerHelper
deepsource-autofix[bot] Sep 19, 2025
585b643
fix build issues
StuartFerguson Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CallbackHandler.IntegrationTests/Common/DockerHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@

namespace CallbackHandler.IntegrationTests.Common
{
public class DockerHelper : global::Shared.IntegrationTesting.DockerHelper
public class CallbackHandlerDockerHelper : global::Shared.IntegrationTesting.DockerHelper
{
public override async Task CreateSubscriptions()

Check warning on line 21 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 21 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
// Nothing to do here
}
Expand Down Expand Up @@ -55,7 +55,7 @@

DockerServices dockerServices = DockerServices.CallbackHandler | DockerServices.EventStore | DockerServices.SqlServer;

this.TestingContext.DockerHelper = new DockerHelper();
this.TestingContext.DockerHelper = new CallbackHandlerDockerHelper();
this.TestingContext.DockerHelper.Logger = logger;
this.TestingContext.Logger = logger;
this.TestingContext.DockerHelper.RequiredDockerServices = dockerServices;
Expand Down Expand Up @@ -92,14 +92,14 @@

public class TestingContext
{
public DockerHelper DockerHelper { get; set; }
public CallbackHandlerDockerHelper DockerHelper { get; set; }
public NlogLogger Logger { get; set; }

public List<Deposit> Deposits { get; set; }

public Dictionary<Guid, String> SentCallbacks { get; set; }

public TestingContext()

Check warning on line 102 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable property 'Deposits' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 102 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable property 'Logger' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.

Check warning on line 102 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable property 'DockerHelper' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
{
this.SentCallbacks = new Dictionary<Guid, string>();
}
Expand All @@ -108,14 +108,14 @@
[Binding]
public class Setup
{
public static IContainerService DatabaseServerContainer;

Check warning on line 111 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable field 'DatabaseServerContainer' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

Check warning on line 111 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable field 'DatabaseServerContainer' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
public static INetworkService DatabaseServerNetwork;

Check warning on line 112 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable field 'DatabaseServerNetwork' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.

Check warning on line 112 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

Non-nullable field 'DatabaseServerNetwork' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the field as nullable.
public static (String usename, String password) SqlCredentials = ("sa", "thisisalongpassword123!");
public static (String url, String username, String password) DockerCredentials = ("https://www.docker.com", "stuartferguson", "Sc0tland");

static object padLock = new object(); // Object to lock on

public static async Task GlobalSetup(DockerHelper dockerHelper)

Check warning on line 118 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.

Check warning on line 118 in CallbackHandler.IntegrationTests/Common/DockerHelper.cs

View workflow job for this annotation

GitHub Actions / Build and Test Pull Requests 

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
ShouldlyConfiguration.DefaultTaskTimeout = TimeSpan.FromMinutes(1);
dockerHelper.SqlCredentials = Setup.SqlCredentials;
Expand Down
Loading