Refactor GetProductPerformanceReport to satisfy 50-line complexity limit

[Copilot]

GetProductPerformanceReport exceeded Codacy's 50-line method limit at 52 lines. Extracted the LINQ query construction and response mapping into dedicated private helpers.

Changes

• ProductPerformanceItemData — new private sealed class replacing the anonymous type in the LINQ projection, allowing the query to be extracted into a separate method
• BuildProductPerformanceQuery — static method encapsulating the transaction/contract join, grouping, and projection logic
• BuildProductPerformanceResponse — instance method encapsulating the ProductPerformanceResponse + ProductPerformanceSummary mapping

Result

GetProductPerformanceReport reduced from 52 → 18 non-blank lines:

public async Task<Result<ProductPerformanceResponse>> GetProductPerformanceReport(...) {
    using ResolvedDbContext<EstateManagementContext>? resolvedContext = ...;
    await using EstateManagementContext context = resolvedContext.Context;

    var grandTotalAmountQuery = (...);
    var grandTotalAmountResult = await ExecuteQuerySafeSum<decimal>(grandTotalAmountQuery, cancellationToken);
    if (grandTotalAmountResult.IsFailed)
        return ResultHelpers.CreateFailure(grandTotalAmountResult);
    var grandTotalAmount = grandTotalAmountResult.Data;

    var query = BuildProductPerformanceQuery(context, request.StartDate, request.EndDate, grandTotalAmount);
    var queryResult = await ExecuteQuerySafeToList(query, cancellationToken);
    if (queryResult.IsFailed)
        return ResultHelpers.CreateFailure(queryResult);
    var queryResults = queryResult.Data;
    if (queryResults.Any() == false)
        return Result.Success(new ProductPerformanceResponse() { ... });

    return Result.Success(BuildProductPerformanceResponse(queryResults));
}

No behavioural changes.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet build EstateReportingAPI.BusinessLogic/EstateReportingAPI.BusinessLogic.csproj --configfile EstateReportingAPI/NuGet.Config (dns block)
  • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp tcp -m owner --uid-owner 0 -j ACCEPT (dns block)
  • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/EstateReportingAPI/EstateReportingAPI/EstateReportingAPI.sln --packages /tmp/codeql-scratch-f294ada2fef3658c/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-f294ada2fef3658c/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-f294ada2fef3658c/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[Complexity] Method ReportingManager::GetProductPerformanceReport has 81 lines of code (limit is 50)</issue_title>
<issue_description>

Codacy ID: f06650655a3977feb4403779c24efb4c

File: EstateReportingAPI.BusinessLogic/ReportingManager.cs
Line: 1150
Rule: Complexity (Warning)
Commit: 785059dbcdc71b92cbcf8e3aa1c57b8c17b2d2fe

Message: Method ReportingManager::GetProductPerformanceReport has 52 lines of code (limit is 50)

**Code Snippet:**
```csharp
    public async Task<Result<ProductPerformanceResponse>> GetProductPerformanceReport(TransactionQueries.ProductPerformanceQuery request, 
```

</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes [Complexity] Method ReportingManager::GetProductPerformanceReport has 81 lines of code (limit is 50) #436

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.