Make date range dynamic in query; improve test assertions#493
Merged
StuartFerguson merged 2 commits intomainfrom Mar 10, 2026
Merged
Make date range dynamic in query; improve test assertions#493StuartFerguson merged 2 commits intomainfrom
StuartFerguson merged 2 commits intomainfrom
Conversation
Updated ReportingManager to use request-supplied start and end dates for grand total amount queries instead of hardcoded values. Enhanced TransactionsEndpointTests by asserting that PercentageOfTotal is non-zero, ensuring more robust test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated ReportingManager to use request-supplied start and end dates for grand total amount queries instead of hardcoded values. Enhanced TransactionsEndpointTests by asserting that PercentageOfTotal is non-zero, ensuring more robust test coverage.
fixes #491