Skip to content

return failure reasons #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024
Merged

return failure reasons #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FileProcessor.FileAggregate/FileAggregate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ public static void PlayEvent(this FileAggregate aggregate, FileLineProcessingSuc

public static void PlayEvent(this FileAggregate aggregate, FileLineProcessingFailedEvent domainEvent)
{

FileLine fileLine = aggregate.FileLines.Single(f => f.LineNumber == domainEvent.LineNumber);
fileLine.TransactionId = domainEvent.TransactionId;
fileLine.ProcessingResult = ProcessingResult.Failed;
Expand Down
3 changes: 2 additions & 1 deletion FileProcessor/Common/ModelFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ public FileDetailsResponse ConvertFrom(Models.FileDetails fileDetails)
LineData = fileDetailsFileLine.LineData,
LineNumber = fileDetailsFileLine.LineNumber,
ProcessingResult = this.TranslateProcessingResult(fileDetailsFileLine.ProcessingResult),
TransactionId = fileDetailsFileLine.TransactionId
TransactionId = fileDetailsFileLine.TransactionId,
RejectionReason = fileDetailsFileLine.RejectedReason
});
}

Expand Down
2 changes: 1 addition & 1 deletion FileProcessor/Controllers/FileController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public async Task<IActionResult> GetFile([FromRoute] Guid fileId,
if (result.IsFailed)
return ResultHelpers.CreateFailure(result).ToActionResultX();

var response = this.ModelFactory.ConvertFrom(result.Data);
DataTransferObjects.Responses.FileDetails response = this.ModelFactory.ConvertFrom(result.Data);

return Result.Success(response).ToActionResultX();

Expand Down
Loading