Refactor Login page to use MediatR commands/queries#1320
Merged
StuartFerguson merged 3 commits intomasterfrom Apr 12, 2026
Merged
Refactor Login page to use MediatR commands/queries#1320StuartFerguson merged 3 commits intomasterfrom
StuartFerguson merged 3 commits intomasterfrom
Conversation
Closed
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 8 |
| Duplication | -1 |
TIP This summary will be updated as you push new changes. Give us feedback
Agent-Logs-Url: https://github.com/TransactionProcessing/SecurityService/sessions/dd2340cb-6f50-432f-baf0-568140d637e5 Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
… surface error messages Agent-Logs-Url: https://github.com/TransactionProcessing/SecurityService/sessions/dd2340cb-6f50-432f-baf0-568140d637e5 Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor login index class to use commands and queries
Refactor Login page to use MediatR commands/queries
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Login
IndexModelhadSignInManager<ApplicationUser>injected directly into the page model constructor. This refactors it to dispatch through MediatR, consistent with the rest of the application.Changes
ExternalProviderDetailsmodel added toSecurityService.Modelsfor use across the business logic layerGetExternalProvidersQueryadded toSecurityServiceQueries— retrieves external auth schemes sorted by display nameLoginCommandadded toSecurityServiceCommands— takesUsername,Password,RememberLoginLoginRequestHandler(new) — handles both the query and command viaSignInManager; distinguishesIsLockedOut,IsNotAllowed, andRequiresTwoFactorstates with specific error messages rather than a generic failureLogin/Index.cshtml.cs— constructor now takes onlyIMediator; failure messages from the handler are surfaced directly toModelStateLoginPageModelTests— updated to mockIMediatorinstead ofSignInManagerThe handler is auto-discovered via the existing
RegisterServicesFromAssembly(typeof(SecurityServiceCommands).Assembly)inProgram.cs— no DI wiring changes required.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
f.feedz.io/usr/bin/dotnet dotnet build SecurityService.slnx --configuration Release(dns block)/usr/bin/dotnet dotnet restore SecurityService.UnitTests/SecurityService.UnitTests.csproj(dns block)/opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp(dns block)If you need me to access, download, or install something from one of these locations, you can either: