Refactor logging system in Shared namespace #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `Shared.Logger` namespace, implementing a comprehensive logging framework with classes such as `ILogger`, `NlogLogger`, `MicrosoftLogger`, and `NullLogger`. The `TenantContext` has been restructured and moved to `Shared.Logger.TennantContext`. Key updates include: - Replaced references to `Shared.TennantContext` with `Shared.Logger.TennantContext`. - Enhanced logging setup in `EventStoreContextTests.cs` using `LogManager.Setup`. - Added a project reference for `Shared.Logger` in the solution file. - Defined the `ILogger` interface for various logging levels. - Updated the `Logger` class to utilize the new interface and initialize different logger types. - Modified `CorrelationIdMiddleware.cs` to log correlation IDs appropriately. These changes improve code organization and enhance the application's logging capabilities.
This commit deletes the `WriteExceptionToLog` and `WriteMessageToLog` static methods from the `TenantContext` class. These methods were used for logging exceptions and messages with tenant-specific support. The associated logging context setup has also been removed.
…erguson/Shared into task/#343_split_out_logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new
Shared.Loggernamespace, implementing a comprehensive logging framework with classes such asILogger,NlogLogger,MicrosoftLogger, andNullLogger. TheTenantContexthas been restructured and moved toShared.Logger.TennantContext.Key updates include:
Shared.TennantContextwithShared.Logger.TennantContext.EventStoreContextTests.csusingLogManager.Setup.Shared.Loggerin the solution file.ILoggerinterface for various logging levels.Loggerclass to utilize the new interface and initialize different logger types.CorrelationIdMiddleware.csto log correlation IDs appropriately.These changes improve code organization and enhance the application's logging capabilities.
closes #343