Skip to content

Add float event tests and improve float creation handling #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 3 commits into from
Feb 23, 2026
Merged

Add float event tests and improve float creation handling #1534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9a3404
Add float event tests and improve float creation handling
StuartFerguson Feb 22, 2026
8c22840
Merge branch 'master' into task/#1508_event_processing_failure
StuartFerguson Feb 22, 2026
636758d
Merge branch 'master' into task/#1508_event_processing_failure
StuartFerguson Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions TransactionProcessor.DatabaseTests/ContractEventTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
using TransactionProcessor.Repository;
using TransactionProcessor.Testing;

namespace TransactionProcessor.DatabaseTests
{
namespace TransactionProcessor.DatabaseTests {
public class MerchantEventTests : BaseTest {
[Fact]
public async Task AddMerchant_MerchantIsAdded()
Expand Down Expand Up @@ -51,8 +50,7 @@ public async Task AddMerchantDevice_EventReplayHandled() {
}

[Fact]
public async Task SwapMerchantDevice_MerchantContractIsAdded()
{
public async Task SwapMerchantDevice_MerchantContractIsAdded() {
Result result = await this.Repository.AddMerchantDevice(TestData.DomainEvents.DeviceAddedToMerchantEvent, CancellationToken.None);
result.IsSuccess.ShouldBeTrue();
result = await this.Repository.SwapMerchantDevice(TestData.DomainEvents.DeviceSwappedForMerchantEvent, CancellationToken.None);
Expand All @@ -70,8 +68,7 @@ public async Task SwapMerchantDevice_MerchantContractIsAdded()
}

[Fact]
public async Task SwapMerchantDevice_EventReplayHandled()
{
public async Task SwapMerchantDevice_EventReplayHandled() {
Result result = await this.Repository.AddMerchantDevice(TestData.DomainEvents.DeviceAddedToMerchantEvent, CancellationToken.None);
result.IsSuccess.ShouldBeTrue();
result = await this.Repository.SwapMerchantDevice(TestData.DomainEvents.DeviceSwappedForMerchantEvent, CancellationToken.None);
Expand Down Expand Up @@ -102,6 +99,28 @@ public async Task SwapMerchantDevice_EventReplayHandled()
}
}

public class FloatEventTests : BaseTest {
[Fact]
public async Task CreateFloat_FloatIsAdded()
{
Result result = await this.Repository.CreateFloat(TestData.DomainEvents.FloatCreatedForContractProductEvent, CancellationToken.None);
result.IsSuccess.ShouldBeTrue();
EstateManagementContext context = this.GetContext();
Float? @float = await context.Floats.SingleOrDefaultAsync(c => c.FloatId == TestData.DomainEvents.FloatCreatedForContractProductEvent.FloatId);
@float.ShouldNotBeNull();
}

[Fact]
public async Task CreateFloat_EventReplayHandled()
{
Result result = await this.Repository.CreateFloat(TestData.DomainEvents.FloatCreatedForContractProductEvent, CancellationToken.None);
result.IsSuccess.ShouldBeTrue();

result = await this.Repository.CreateFloat(TestData.DomainEvents.FloatCreatedForContractProductEvent, CancellationToken.None);
result.IsSuccess.ShouldBeTrue();
}
}


public class StatementEventTests : BaseTest {
[Fact]
Expand Down
2 changes: 1 addition & 1 deletion TransactionProcessor.Repository/ITransactionProcessorReadModelRepository.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,7 @@ public async Task<Result> CreateFloat(FloatDomainEvents.FloatCreatedForContractP
ProductId = domainEvent.ProductId
};
await context.Floats.AddAsync(floatRecord, cancellationToken);
return await context.SaveChangesAsync(cancellationToken);
return await context.SaveChangesWithDuplicateHandling(cancellationToken);
}

public async Task<Result> CreateFloatActivity(FloatDomainEvents.FloatCreditPurchasedEvent domainEvent,
Expand Down
4 changes: 2 additions & 2 deletions TransactionProcessor.Testing/TestData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2587,7 +2587,7 @@ public static MerchantStatementAggregate BuiltMerchantStatementAggregate()
public static String DepositAccountNumber = "12345678";
public static Guid DepositHostIdentifier = Guid.Parse("1D1BD9F0-D953-4B2A-9969-98D3C0CDFA2A");
public static String DepositSortCode = "112233";

public static Models.Merchant.Merchant MerchantModelWithAddressesContactsDevicesAndOperatorsAndContracts(Models.Merchant.SettlementSchedule settlementSchedule = Models.Merchant.SettlementSchedule.Immediate) =>
new Models.Merchant.Merchant
{
Expand Down Expand Up @@ -2627,7 +2627,7 @@ public static Models.Merchant.Merchant MerchantModelWithAddressesContactsDevices
};

public static class DomainEvents {

public static FloatDomainEvents.FloatCreatedForContractProductEvent FloatCreatedForContractProductEvent => new FloatDomainEvents.FloatCreatedForContractProductEvent(FloatAggregateId, EstateId, ContractId, VariableContractProductId, FloatCreatedDateTime);
public static TransactionDomainEvents.TransactionHasBeenCompletedEvent TransactionHasBeenCompletedEvent => new TransactionDomainEvents.TransactionHasBeenCompletedEvent(TestData.TransactionId,
TestData.EstateId,
TestData.MerchantId,
Expand Down
Loading