Add missing test coverage for MerchantStatementDomainService#1541
Merged
StuartFerguson merged 3 commits intomasterfrom Feb 23, 2026
Merged
Add missing test coverage for MerchantStatementDomainService#1541StuartFerguson merged 3 commits intomasterfrom
StuartFerguson merged 3 commits intomasterfrom
Conversation
Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update test coverage on merchant statement domain service
Add missing failure-path test coverage for MerchantStatementDomainService
Feb 23, 2026
Member
|
@copilot can you add exception cases to the tests for each method |
Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Contributor
Author
Added exception test cases for all 8 methods in commit 9059e68. Each test configures the first mock call to |
Copilot
AI
changed the title
Add missing failure-path test coverage for MerchantStatementDomainService
Add missing test coverage for MerchantStatementDomainService
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each method in
MerchantStatementDomainServicelacked tests for aggregate fetch failures, save failures, and unhandled exceptions — leaving entire error-handling branches uncovered.Added test cases
AddTransactionToStatement—MerchantStatementForDateAggregatefetch failure; exception thrownAddSettledFeeToStatement—MerchantStatementForDateAggregatefetch failure; exception thrownAddDepositToStatement—MerchantStatementForDateAggregatefetch failure; save failure; exception thrownAddWithdrawalToStatement—MerchantStatementForDateAggregatefetch failure; save failure; exception thrownRecordActivityDateOnMerchantStatement—MerchantStatementAggregatefetch failure; exception thrownGenerateStatement—MerchantStatementAggregatefetch failure; exception thrownBuildStatement—MerchantStatementAggregatefetch failure;IStatementBuilder.GetStatementHtmlfailure; exception thrownEmailStatement—MerchantStatementAggregatefetch failure; save failure; exception thrownEach test follows the existing Moq/Shouldly/
TestDataconventions. Failure-path tests useReturnsAsync(Result.Failure())and exception tests use.ThrowsAsync(new Exception("Test exception")), assertingresult.IsFailed.ShouldBeTrue()in both cases:Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.