Skip to content

Improve SOAP reply logging and fix log type in requests #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 2 commits into from
Mar 3, 2026
Merged

Improve SOAP reply logging and fix log type in requests #1573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42ad769
Improve SOAP reply logging and fix log type in requests
StuartFerguson Mar 3, 2026
81ca972
Merge branch 'master' into bug/#1554_client_message_logger_tweaks
StuartFerguson Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions TransactionProcessor/Common/ClientMessageLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.Extensions.Logging;
using System.Net;
using Microsoft.Extensions.Logging;
using Shared.Middleware;

namespace TransactionProcessor.Common;
Expand Down Expand Up @@ -38,12 +39,28 @@ public ClientMessageLogger(String clientName, RequestResponseMiddlewareLoggingCo

#region Methods

public void AfterReceiveReply(ref Message reply, Object correlationState) => LogMessage(LogType.Request,$"Received SOAP reply from {this.ClientName}:\r\n{reply}");

public void AfterReceiveReply(ref Message reply, Object correlationState) {

if (reply.Properties.TryGetValue(
HttpResponseMessageProperty.Name,
out object httpResponseObj))
{
HttpResponseMessageProperty httpResponse = (HttpResponseMessageProperty)httpResponseObj;

HttpStatusCode statusCode = httpResponse.StatusCode;
if (statusCode != HttpStatusCode.OK) {
Logger.LogWarning($"Received failed SOAP reply from {this.ClientName}:\r\n{reply}");
return;
}

LogMessage(LogType.Response, $"Received SOAP reply from {this.ClientName}:\r\n{reply}");
}
}


public Object BeforeSendRequest(ref Message request, IClientChannel channel)
{
LogMessage(LogType.Response, $"Sending SOAP request to {this.ClientName}:\r\n{request}");
LogMessage(LogType.Request, $"Sending SOAP request to {this.ClientName}:\r\n{request}");
return null;
}

Expand Down
Loading