Add read-model merchant schedule endpoint and use it in schedule creation validation

[Copilot]

Merchant schedules could be created and updated, but the validation flow was still reading schedule state from the aggregate path. This change adds a dedicated read-model-backed merchant schedule endpoint and updates the SpecFlow schedule creation flow to validate the projected database state by merchant and year.

• Read-model schedule API

  • Added GET /api/estates/{estateId}/merchants/{merchantId}/schedules/{year}/readmodel
  • Returns MerchantScheduleResponse for a single merchant/year from the read-model database
  • Keeps the existing aggregate-backed GetMerchantSchedule endpoint unchanged

• Repository and query path

  • Added a read-model repository lookup for merchant schedule + month rows
  • Wired the new path through:
    • repository
    • manager
    • MediatR query/handler
    • HTTP handler/endpoint
    • client API

• SpecFlow validation

  • Updated WhenICreateTheFollowingMerchantSchedules to validate via the new read-model endpoint
  • This now checks the projected schedule that the system persists to the read model, not just aggregate state
  • Closed-day comparison remains order-insensitive

• Robustness

  • Read-model ClosedDays parsing now tolerates malformed persisted values instead of throwing during schedule retrieval

merchantGroup.MapGet(
    "/{merchantId:guid}/schedules/{year:int}/readmodel",
    MerchantHandlers.GetMerchantScheduleFromReadModel)
    .WithName("GetMerchantScheduleFromReadModel");

// SpecFlow validation now uses the read-model projection
await this.TransactionProcessorClient.GetMerchantScheduleFromReadModel(
    accessToken,
    scheduleRequest.estate.EstateId,
    scheduleRequest.merchantId,
    scheduleRequest.request.Year,
    CancellationToken.None);

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter TransactionProcessorManager_GetMerchantSchedule -p:RestoreIgnoreFailedSources=true -nologo (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter GetMerchantScheduleFromReadModel -p:RestoreIgnoreFailedSources=true -nologo (dns block)
  • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.24.2/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Merchant Schedule</issue_title>
<issue_description>New endpoint to allow setting of merchant open/closed days over a year.

This can vary each year,

Can you give me a plan of how to implement this in a new Merchant Schedule Aggregate including requests to create/update schedules over the year, I am using event sourcing so ideas for events would be great also.

What I don't want however is an event for every date stating the merchant is open or closed.

Maybe have a event per month to keep the event size down.

Have a look at the other Aggregates to get a feel for how they are structured.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Merchant Schedule #1539

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[StuartFerguson]

@copilot is there any need for the MerchantScheduleCreatedEvent ?

[Copilot]

@copilot is there any need for the MerchantScheduleCreatedEvent ?

Not strictly. It’s only useful if we want to represent a schedule year existing before any month overrides are added, or allow an intentionally empty schedule for a year. Because the month event already carries EstateId, MerchantId and Year, we could remove MerchantScheduleCreatedEvent and treat the first month update as implicit creation; the trade-off is losing that explicit lifecycle/empty-schedule state. If you want, I can simplify it that way in a follow-up.

[StuartFerguson]

@copilot ok maybe a compromise and have the created event and the update events only indicate which days the merchant is closed?

[Copilot]

@copilot ok maybe a compromise and have the created event and the update events only indicate which days the merchant is closed?

Done in 642c43a. I kept the created event for the explicit schedule lifecycle, and simplified the month update event/model/request path so month updates now only carry ClosedDays.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.Aggregates.Tests/TransactionProcessor.Aggregates.Tests.csproj --no-restore --filter MerchantScheduleAggregateTests -nologo (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.Aggregates.Tests/TransactionProcessor.Aggregates.Tests.csproj --filter MerchantScheduleAggregateTests -p:RestoreIgnoreFailedSources=true -nologo (dns block)
  • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.24.3/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[StuartFerguson]

@copilot ok can you now expand this get the request from the minimal api endpoint to the aggregate, this means changes to the domain service and request handler

[Copilot]

@copilot ok can you now expand this get the request from the minimal api endpoint to the aggregate, this means changes to the domain service and request handler

Done in f622296. I wired create/update merchant schedule requests from the merchant minimal API endpoints through MerchantHandlers, MerchantCommands, MerchantRequestHandler, and MerchantDomainService into MerchantScheduleAggregate, using a deterministic aggregate id based on estate, merchant, and year.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter MerchantSchedule -p:RestoreIgnoreFailedSources=true -nologo (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter Mediator_Send_RequestHandled -p:RestoreIgnoreFailedSources=true -nologo _TOKEN"; }; f (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter MerchantSchedule -p:RestoreIgnoreFailedSources=true -nologo _TOKEN"; }; f (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[StuartFerguson]

@copilot i need you to now update my ReadModelDomainEventHandler, Repository and Database context to get this data feeing into my Read Model

[Copilot]

@copilot i need you to now update my ReadModelDomainEventHandler, Repository and Database context to get this data feeing into my Read Model

Done in 297c0a2. I wired MerchantScheduleCreatedEvent and MerchantScheduleMonthUpdatedEvent through ReadModelDomainEventHandler into the read-model repository, added DbContext/entities plus a migration for persisted schedule header/month rows, and mapped projected schedules back onto the merchant read model/API response. Targeted validation was attempted, but sandbox restore is still blocked by the private Feedz NuGet source (NU1801/NU1101).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter ReadModelDomainEventHandler -p:RestoreIgnoreFailedSources=true -nologo (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter MerchantScheduleDomainEventHandler -p:RestoreIgnoreFailedSources=true -nologo (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/TransactionProcessor/TransactionProcessor/TransactionProcessor.Tests/TransactionProcessor.Tests.csproj --filter ModelFactory_Merchant_IsConverted -p:RestoreIgnoreFailedSources=true -nologo (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)