Harden transaction request deserialization by removing unsafe TypeNameHandling#1716
Merged
StuartFerguson merged 8 commits intomasterfrom Apr 7, 2026
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 20 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionProcessor/sessions/bfdb0a31-569c-4af9-8aed-24585bddaba2 Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionProcessor/sessions/bfdb0a31-569c-4af9-8aed-24585bddaba2 Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix security issue with TypeNameHandling Auto in JSON serializer
Harden transaction request deserialization by removing unsafe TypeNameHandling
Apr 7, 2026
Member
|
@copilot code looks fine but can you address the codacy issues please |
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionProcessor/sessions/993da4db-bf95-492f-b14f-db3a9aafdee6 Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionProcessor/sessions/993da4db-bf95-492f-b14f-db3a9aafdee6 Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Contributor
Author
Addressed the Codacy follow-ups in 5bde6c9. I tightened the transaction request deserialization helper to use explicit safe Newtonsoft settings and improved the failure path/messages, then re-ran the focused handler tests and the full TransactionProcessor.Tests project successfully. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionProcessor/sessions/1ae8aa2f-81c5-4116-b58a-576d0dd35a9c Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
Agent-Logs-Url: https://github.com/TransactionProcessing/TransactionProcessor/sessions/649d1ab7-7f95-4ba3-9893-fd31c0eb1827 Co-authored-by: StuartFerguson <16325469+StuartFerguson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.