Reduce ModelFactory.ConvertFrom parameter count from 9 to 8

[Copilot]

ModelFactory.ConvertFrom(Guid, MerchantEntity, ...) in TransactionProcessor.Repository had 9 parameters, violating the Codacy complexity rule (limit: 8).

Changes

• ModelFactory.cs — Collapsed the two related schedule parameters into a single named tuple, bringing the count to 8:

// Before
public static MerchantModel ConvertFrom(Guid estateId, MerchantEntity merchant,
    List<MerchantAddressEntity> merchantAddresses, List<MerchantContactEntity> merchantContacts,
    List<MerchantOperatorEntity> merchantOperators, List<MerchantDeviceEntity> merchantDevices,
    List<MerchantSecurityUserEntity> merchantSecurityUsers,
    List<MerchantScheduleEntity> merchantSchedules,
    List<MerchantScheduleMonthEntity> merchantScheduleMonths)

// After
public static MerchantModel ConvertFrom(Guid estateId, MerchantEntity merchant,
    List<MerchantAddressEntity> merchantAddresses, List<MerchantContactEntity> merchantContacts,
    List<MerchantOperatorEntity> merchantOperators, List<MerchantDeviceEntity> merchantDevices,
    List<MerchantSecurityUserEntity> merchantSecurityUsers,
    (List<MerchantScheduleEntity> Schedules, List<MerchantScheduleMonthEntity> Months) merchantScheduleData)

• ITransactionProcessorReadModelRepository.cs (line ~357) — Call site that passed 7 null arguments switched to the existing 2-parameter overload.
• ITransactionProcessorReadModelRepository.cs (line ~890) — Call site updated to pass the named tuple: (Schedules: s, Months: merchantScheduleMonths).

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet build TransactionProcessor.Repository/TransactionProcessor.Repository.csproj --no-restore -nologo (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test TransactionProcessor.Tests/TransactionProcessor.Tests.csproj --no-restore -nologo (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test TransactionProcessor.Tests/TransactionProcessor.Tests.csproj --no-restore -nologo -v normal (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}