Refactor: introduce ClientBase and update client usage#1754
Merged
Conversation
Add abstract ClientBase for reusable HTTP logic with generic methods for all HTTP verbs, error handling, and custom headers. Refactor TransactionProcessorClient to inherit from ClientBase and use its methods, replacing SendHttp*Request calls. Serialization is now handled via injected delegates using Newtonsoft.Json, improving maintainability and consistency.
Up to standards ✅🟢 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 1 minor |
🟢 Metrics 6 complexity · 21 duplication
Metric Results Complexity 6 Duplication 21
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
- Remove all references to messagingService scope, resource, and client from feature files and generated code - Update transaction tables to leave CustomerEmailAddress empty for some transactions - Comment out receipt resend scenario in feature and generated files - Send empty StringContent in ProcessSettlement POST request - Add result success assertion in settlement processing step - Rename table variables in generated code for clarity - Ensure only transactionProcessor scope is used in test setup and data
…ctionProcessing/TransactionProcessor into task/various_codacy_fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add abstract ClientBase for reusable HTTP logic with generic methods for all HTTP verbs, error handling, and custom headers. Refactor TransactionProcessorClient to inherit from ClientBase and use its methods, replacing SendHttp*Request calls. Serialization is now handled via injected delegates using Newtonsoft.Json, improving maintainability and consistency.