Refactor transaction validation and state management #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `TransactionValidationServiceTests` to include `Shared.General` and refactored constructor; removed several test methods for simplification. - Added new record type `TransactionValidationResult<T>` in `ITransactionValidationService.cs` for enhanced data handling. - Significant refactoring in `TransactionValidationService.cs` to improve validation methods and introduce generics for better type safety. - Updated `IStateDispatcher` and `EventHandler` interfaces to use the new `Shared.EventStore.ProjectionEngine.State` namespace. - Aligned `StateProjectionEventHandler`, `ProjectionHandler`, and `IProjection` interfaces with the new state management architecture. - Refactored `MerchantBalanceState` and `State` classes to inherit from the new state structure. - Updated `VoucherState` to ensure consistency across all state-related classes.
github-actions
bot
deleted the
task/#606_txn_validation_service_refactor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransactionValidationServiceTeststo includeShared.Generaland refactored constructor; removed several test methods for simplification.TransactionValidationResult<T>inITransactionValidationService.csfor enhanced data handling.TransactionValidationService.csto improve validation methods and introduce generics for better type safety.IStateDispatcherandEventHandlerinterfaces to use the newShared.EventStore.ProjectionEngine.Statenamespace.StateProjectionEventHandler,ProjectionHandler, andIProjectioninterfaces with the new state management architecture.MerchantBalanceStateandStateclasses to inherit from the new state structure.VoucherStateto ensure consistency across all state-related classes.