Refactor estate client to use IIntermediateEstateClient #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced instances of IEstateClient with IIntermediateEstateClient across multiple test files and service implementations. This change affects test classes such as FloatDomainServiceTests, SettlementDomainServiceTests, TransactionDomainServiceTests, and TransactionValidationServiceTests, as well as service classes like FloatDomainService, SettlementDomainService, and VoucherDomainService. The new IIntermediateEstateClient interface wraps the existing IEstateClient, enhancing the architecture by introducing an intermediate layer for estate client operations, improving separation of concerns and facilitating easier testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced instances of IEstateClient with IIntermediateEstateClient across multiple test files and service implementations. This change affects test classes such as FloatDomainServiceTests, SettlementDomainServiceTests, TransactionDomainServiceTests, and TransactionValidationServiceTests, as well as service classes like FloatDomainService, SettlementDomainService, and VoucherDomainService. The new IIntermediateEstateClient interface wraps the existing IEstateClient, enhancing the architecture by introducing an intermediate layer for estate client operations, improving separation of concerns and facilitating easier testing.