Refactor event access and enhance resilience in handlers #736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the access to `TransactionHasBeenCompletedEvent` by introducing a `DomainEvents` class within `TestData`, improving organization and consistency across test files. Additionally, retry policies using the Polly library have been implemented in the `MerchantStatementDomainEventHandler` to enhance event handling resilience. The corresponding test class has been updated to utilize the new event structure. These changes promote better maintainability and readability of the code while ensuring robust handling of transient failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the access to
TransactionHasBeenCompletedEventby introducing aDomainEventsclass withinTestData, improving organization and consistency across test files.Additionally, retry policies using the Polly library have been implemented in the
MerchantStatementDomainEventHandlerto enhance event handling resilience. The corresponding test class has been updated to utilize the new event structure.These changes promote better maintainability and readability of the code while ensuring robust handling of transient failures.