Refactor FloatDomainService to use IAggregateService #772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
StuartFerguson
commented
Apr 17, 2025
StuartFerguson
commented
- Updated FloatDomainServiceTests to utilize IAggregateService, simplifying test setup and reducing dependencies.
- Replaced multiple IAggregateRepository dependencies in FloatDomainService with a single IAggregateService for improved maintainability.
- Introduced IAggregateRepositoryResolver for dynamic repository resolution.
- Added AggregateService for aggregate retrieval, saving, and caching.
- Updated project file to include prometheus-net for metrics collection.
- Modified RepositoryRegistry to register new services for dependency injection.
- Enhanced Startup.cs to include Prometheus middleware for monitoring.
- Introduced AggregateMemoryCache for efficient aggregate caching.
- Updated FloatDomainServiceTests to utilize IAggregateService, simplifying test setup and reducing dependencies. - Replaced multiple IAggregateRepository dependencies in FloatDomainService with a single IAggregateService for improved maintainability. - Introduced IAggregateRepositoryResolver for dynamic repository resolution. - Added AggregateService for aggregate retrieval, saving, and caching. - Updated project file to include prometheus-net for metrics collection. - Modified RepositoryRegistry to register new services for dependency injection. - Enhanced Startup.cs to include Prometheus middleware for monitoring. - Introduced AggregateMemoryCache for efficient aggregate caching.
This commit refactors the MerchantDomainServiceTests class to replace multiple IAggregateRepository dependencies with a single IAggregateService dependency, simplifying the test setup and reducing the number of mocked repositories. The MerchantDomainService constructor has been updated to accept the new service, promoting a more cohesive design. Various test methods have been modified to utilize AggregateService methods for fetching and saving aggregates, ensuring alignment with the new architecture. The logic within MerchantDomainService methods has also been updated accordingly. All tests have been adjusted to validate expected outcomes, confirming that functionality remains intact while enhancing code structure and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.