Skip to content

merchant aggregate converted to using results #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2025
Merged

merchant aggregate converted to using results #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c784b3d
merchant aggregate converted to using results
StuartFerguson Sep 5, 2025
a88a6c2
fix codacy issues
StuartFerguson Sep 6, 2025
05f34fb
another code review fix
StuartFerguson Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
708 changes: 397 additions & 311 deletions TransactionProcessor.Aggregates.Tests/MerchantAggregateTests.cs
View file
Open in desktop

Large diffs are not rendered by default.

45 changes: 30 additions & 15 deletions TransactionProcessor.Aggregates.Tests/MerchantDepositListAggregateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using Shared.EventStore.Aggregate;
using Shared.ValueObjects;
using Shouldly;
using TransactionProcessor.Models.Merchant;
Expand All @@ -12,7 +13,8 @@ public class MerchantDepositListAggregateTests
[Fact]
public void MerchantDepositListAggregate_Create_IsCreated() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -26,7 +28,8 @@ public void MerchantDepositListAggregate_Create_IsCreated() {
public void MerchantDepositListAggregate_Create_AlreadyCreated_IsCreated()
{
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -49,7 +52,8 @@ public void MerchantDepositListAggregate_Create_MerchantNotCreated_ErrorThrown()
[Fact]
public void MerchantDepositListAggregate_MakeDeposit_AutomaticDepositSource_DepositMade() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -70,7 +74,8 @@ public void MerchantDepositListAggregate_MakeDeposit_AutomaticDepositSource_Depo
[Fact]
public void MerchantDepositListAggregate_MakeDeposit_DepositMade() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -89,7 +94,8 @@ public void MerchantDepositListAggregate_MakeDeposit_DepositMade() {
[Fact]
public void MerchantDepositListAggregate_MakeDeposit_DepositSourceNotSet_ErrorThrown() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -105,7 +111,8 @@ public void MerchantDepositListAggregate_MakeDeposit_DepositSourceNotSet_ErrorTh
[Fact]
public void MerchantDepositListAggregate_MakeDeposit_DuplicateDeposit_ErrorThrown() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand Down Expand Up @@ -137,7 +144,8 @@ public void MerchantDepositListAggregate_MakeDeposit_MerchantDepositListNotCreat
[Fact]
public void MerchantDepositListAggregate_MakeDeposit_TwoDeposits_BothDepositsMade() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -155,7 +163,8 @@ public void MerchantDepositListAggregate_MakeDeposit_TwoDeposits_BothDepositsMad
[Fact]
public void MerchantDepositListAggregate_MakeDeposit_TwoDepositsOneMonthApartSameDetails_BothDepositsMade() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -176,7 +185,8 @@ public void MerchantDepositListAggregate_MakeDeposit_TwoDepositsOneMonthApartSam
[Fact]
public void MerchantDepositListAggregate_MakeDeposit_TwoDepositsSameDetailsApartFromAmounts_BothDepositsMade() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -197,7 +207,8 @@ public void MerchantDepositListAggregate_MakeDeposit_TwoDepositsSameDetailsApart
[Fact]
public void MerchantDepositListAggregate_MakeWithdrawal_DuplicateWithdrawal_ErrorThrown() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -219,7 +230,8 @@ public void MerchantDepositListAggregate_MakeWithdrawal_MerchantDepositListNotCr
[Fact]
public void MerchantDepositListAggregate_MakeWithdrawal_TwoWithdrawals_BothWithdrawalsMade() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -234,7 +246,8 @@ public void MerchantDepositListAggregate_MakeWithdrawal_TwoWithdrawals_BothWithd
[Fact]
public void MerchantDepositListAggregate_MakeWithdrawal_TwoWithdrawalsOneMonthApartSameDetails_BothWithdrawalsMade() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -249,7 +262,8 @@ public void MerchantDepositListAggregate_MakeWithdrawal_TwoWithdrawalsOneMonthAp
[Fact]
public void MerchantDepositListAggregate_MakeWithdrawal_TwoWithdrawalsSameDetailsApartFromAmounts_BothWithdrawalsMade() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);
Expand All @@ -264,14 +278,15 @@ public void MerchantDepositListAggregate_MakeWithdrawal_TwoWithdrawalsSameDetail
[Fact]
public void MerchantDepositListAggregate_MakeWithdrawal_WithdrawalMade() {
MerchantAggregate merchantAggregate = MerchantAggregate.Create(TestData.MerchantId);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated);
merchantAggregate.Create(TestData.EstateId, TestData.MerchantName, TestData.DateMerchantCreated, TestData.AddressModel, TestData.ContactModel,
TestData.SettlementScheduleModel);

MerchantDepositListAggregate merchantDepositListAggregate = MerchantDepositListAggregate.Create(TestData.MerchantId);
merchantDepositListAggregate.Create(merchantAggregate, TestData.DateMerchantCreated);

merchantDepositListAggregate.MakeWithdrawal(TestData.WithdrawalDateTime, TestData.WithdrawalAmount);

var withdrawalListModel = merchantDepositListAggregate.GetWithdrawals();
List<Withdrawal> withdrawalListModel = merchantDepositListAggregate.GetWithdrawals();
withdrawalListModel.ShouldHaveSingleItem();

withdrawalListModel.Single().WithdrawalDateTime.ShouldBe(TestData.WithdrawalDateTime);
Expand Down
Loading
Loading